Yukky VLR Update

#1

yukky

Hi

Updated my extension and fixed a pretty big bug caused by BetterVLR (If you are thinking of forking the extension itself, please read my bug fix)

[ORIGINAL THREAD]: https://www.vlr.gg/553254/yukkys-vlr/

DOWNLOAD

[CHROME]: https://chromewebstore.google.com/detail/yukkys-vlr/amaeclehaljnafaacbhnilcmgflgfhh
[FIREFOX]: https://addons.mozilla.org/en-US/firefox/addon/yukkys-vlr/

WHATS CHANGED?

NEW

Added ability to view a player's stats in a specific tourney on their player page:

https://i.imgur.com/S8eXLJL.gif

EXPERIMENTAL: Ability to stack tourney ratings in compare page (i.e compare all international master stats between two players)
- NOTE: THIS IS EXPERIMENTAL AND MUST BE ENABLED IN SETTINGS (EXPECT BUGS FOR NOW)

https://i.imgur.com/zYzBqri.png

BUG FIXES

FIxed agent filtering issues on compare page
Sped up URL reading on compare page
BetterVLR Major Bug Fix:
The original BetterVLR introduced a commit
([61251aad0999ba6c45fe3fd833a898174730f329](https://github.com/myhiy/BetterVLR/commit/61251aad0999ba6c45fe3fd833a898174730f329))
that basically did a link nuke:
```
$(".post-body").find("a").each(function () {
const img_src = this.href;
const img = $(`<img style="display:none" src="${img_src}" href="${img_src}">`)
    .on("load", function () {
        $(this).addClass("post-image").show();
    })
    .on("error", function () {
        $(this).remove();
    });

$(this).parent().append(img);
});
```
The above code would cause people who used a forked version of BetterVLR to basically get IP banned for one hour if they opened up a thread containing a lot of links. This version of the code was never published as a build on the chrome web store, which is why the issue never popped up for users of the official BetterVLR extension, only forks that pulled in this repo.

#2

notapandaa

6

Frags

+

–

goat + bump
btw 1 star review is wild someone give him reviews :|

#3

simbhdri

1

Frags

+

–

got our first patch note boys

#5

yukky

1

Frags

+

–

pretty big one

better vlr devs left a nuke in their code for people who forked it looool

#21

ash_knuckles

0

Frags

+

–

wait why does it IP ban you? cause of this?

$(this).remove();

#22

yukky

0

Frags

+

–

no its the part where it tries to convert all links into img tags

#25

ash_knuckles

0

Frags

+

–

why does it IP ban u tho? i don't know enough jquery to tell

#28

ash_knuckles

0

Frags

+

–

best guess is not appending the tags statically as in previous commit kinda just buttfucks the server so much it puts you in the corner for a bit

kek

#29

yukky

0

Frags

+

–

it’s not jquerys fault

it’s just poorly written code

so what happens is that the code looks for links on the page and loads them as sources for img tags

then the img tag doing what it does makes a request to that src link to fetch that image, but in our case it was whatever link was on the page

so now imagine you open a pickem thread that has countless vlr links on it

the code loads those pickem links into img tags, the img tags in rapid succession makes an equal amount of requests to vlr thinking it’s getting an image. unfortunately, the requests in turn look like ddos/webscraping attempts to cloudflare causing cloudflare to ban your ip for a duration

#30

dimmed

0

Frags

+

–

omg thats why I couldnt use pickems. I tried doing my playoffs pickems and would just get banned for vlr for a bit. Glad you figured it out, I ended up just disabling the extension for a while

#32

yukky

0

Frags

+

–

ya better vlr left a nuke that i couldn’t figure out for the longest time

had to refresh my ip like 30 times until i figured it out

#4

Lordsalih

1

Frags

+

–

W, i just downloaded the extension

#6

satellite_kov

1

Frags

+

–

brenno luan must be found. we know its one of us.

#7

HammerDJ

3

Frags

+

–

who tf hating my g on Chrome Web Store 😭😭😭

One 1-star rating 🥀🥀🥀

#8

yukky

1

Frags

+

–

idk….need to find him

#9

satellite_kov

1

Frags

+

–

more reviews came in w

#10

MrBlooBloom

0

Frags

+

–

you're truly insane man

#11

CaxTonYT

0

Frags

+

–

i trust you. thanks so much for this

#12

Conceit

0

Frags

+

–

Idk it has 1 star that must mean it's bad...

#13

yukky

0

Frags

+

–

are u brenno luan

#14

yukky

0

Frags

+

–

wowwwwww shamelesss bump wowwwwww

#15

yukky

1

Frags

+

–

who the hell is bumping this?

#16

Laundry

1

Frags

+

–

mb

#17

yukky

0

Frags

+

–

its ok keep it up

#18

yukky

0

Frags

+

–

pow

#19

Laundry

0

Frags

+

–

kachow

#35

Laundry

0

Frags

+

–

kachinga

#36

Laundry

0

Frags

+

–

KAPOWWWWW

#37

Laundry

0

Frags

+

–

Katoozie

#20

229fn

1

Frags

+

–

is there a firefox version?

#23

yukky

0

Frags

+

–

🌛🌛🌛

#24

HammerDJ

0

Frags

+

–

++ I don't use chrome Mr. John Yukky

#33

yukky

1

Frags

+

–

THERE IS NOW A FIREFOX VERSION!

#34

HammerDJ

0

Frags

+

–

GOATED :D

Thank you Mr. John Yukky <3

EDIT: Works like a charm :D

#26

Laundry

0

Frags

+

–

If he open sources it u might be able to just update the manifest and it’ll work i think

(I think, idk the specifics for this project but last chrome extension project I worked on I did that just fine)

#27

Laundry

0

Frags

+

–

Big problem with publishing it instead of running it in developer mode would be having to go through the security process again with both Mozilla and google cuz they are PAINFULLL

#31

yukky

0

Frags

+

–

i got it approved on firefox actually but i need to update to my latest version