I get that popular vote is probably the Xbox One controller (there's a reason it didn't swap from the XBONE to the Series X). Personally I'm a big fan of the GameCube controller, Nintendo were low-key a second full joystick and analogue trigger away from perfection.
Personally not a huge dual shock fan anymore the Dual Shock 2 was fire but i wasn't really a fan of the skinny way they do the analogue triggers on the new ones.
And shout out the Logitech F310 for is dual purpose of games and submarine steering

